Skip to content

Backport #16822 to v3.5#17196

Closed
amit-rastogi wants to merge 1 commit into
etcd-io:release-3.5from
amit-rastogi:backport-16822-v3.5
Closed

Backport #16822 to v3.5#17196
amit-rastogi wants to merge 1 commit into
etcd-io:release-3.5from
amit-rastogi:backport-16822-v3.5

Conversation

@amit-rastogi

@amit-rastogi amit-rastogi commented Jan 3, 2024

Copy link
Copy Markdown

This PR is currently in DRAFT mode.

As part of #15247, backporting #16822 to 3.5 branch will be done in 2 steps-

  1. Backport testutils.ExecuteUntil to 3.5 branch since tests/e2e/v3_lease_no_proxy_test.go makes use of testutils.ExecuteUntil (Completed as part of Backport testutils.ExecuteUntil to 3.5 branch #17177)

  2. Backport changes in Ignore old leader's leases revoking request #16822 to 3.5 branch

This PR addresses point 2 above. In the first draft of this PR, following changes have been done-

There would be additional dependencies, not part of #16822, that need to be backported in further commits as part of this same PR.

Following changes done as part of commit (Added additional dependencies in e2e framework)-
Backported following methods in EtcdProcessCluster
EndpointsGRPC
Etcdctl
WaitMembersForLeader
WaitLeader

Added tests/framework/config/client.go

Updated below structs
ClientConfig
EtcdProcessClusterConfig
EtcdProcess

, to be backported in further commits

Signed-off-by: Amit Rastogi <amitrastogi2206@gmail.com>
@k8s-ci-robot

Copy link
Copy Markdown

Hi @amit-rastogi. Thanks for your PR.

I'm waiting for a etcd-io member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ahrtr

ahrtr commented Jan 8, 2024

Copy link
Copy Markdown
Member

Following changes done as part of commit (Added additional dependencies in e2e framework)- Backported following methods in EtcdProcessCluster EndpointsGRPC Etcdctl WaitMembersForLeader WaitLeader

Added tests/framework/config/client.go

Updated below structs ClientConfig EtcdProcessClusterConfig EtcdProcess

Please do it in a separate PR.

@ahrtr

ahrtr commented Jan 26, 2024

Copy link
Copy Markdown
Member

@amit-rastogi any update and are you still working on this PR and #17240?

@ahrtr

ahrtr commented Feb 1, 2024

Copy link
Copy Markdown
Member

Talked with the the amit-rastogi, he will not continue to work on this PR.

@ahrtr ahrtr closed this Feb 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Development

Successfully merging this pull request may close these issues.

3 participants