Backport testutils.ExecuteUntil to 3.5 branch

[amit-rastogi]

As part of #15247, backporting #16822 to 3.5 branch will be done in 2 steps-

1. backport testutils.ExecuteUntil to 3.5 branch since tests/e2e/v3_lease_no_proxy_test.go makes use of testutils.ExecuteUntil
2. backport changes in Ignore old leader's leases revoking request #16822 to 3.5 branch

This PR addresses Step 1 above.

[k8s-ci-robot]

Hi @amit-rastogi. Thanks for your PR.

I'm waiting for a etcd-io member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[jmhbnz]

Hey @amit-rastogi - Please ensure your commit is signed so the developer certificate of origin (DCO) check passes, i.e:

git rebase HEAD~1 --signoff
git push --force

/ok-to-test

Note: It looks like tests/e2e/v3_lease_no_proxy_test.go only has the one reference to testutils.ExecuteUntil. As an alternative we could slightly tweak that line to instead call executeWithTimeout which is what other e2e tests in release-3.5 currently do, refer example https://github.com/etcd-io/etcd/blob/release-3.5/tests/e2e/ctl_v3_grpc_test.go#L112. I think my preference would be to keep the backport as minimal as possible to just tweak to use executeWithTimeout but I defer to maintainers on which approach is preferred.

[amit-rastogi]

Hey @amit-rastogi - Please ensure your commit is signed so the developer certificate of origin (DCO) check passes, i.e:

git rebase HEAD~1 --signoff
git push --force

/ok-to-test

Note: It looks like tests/e2e/v3_lease_no_proxy_test.go only has the one reference to testutils.ExecuteUntil. As an alternative we could slightly tweak that line to instead call executeWithTimeout which is what other e2e tests in release-3.5 currently do, refer example https://github.com/etcd-io/etcd/blob/release-3.5/tests/e2e/ctl_v3_grpc_test.go#L112. I think my preference would be to keep the backport as minimal as possible to just tweak to use executeWithTimeout but I defer to maintainers on which approach is preferred.

Thanks @jmhbnz for the feedback. I'll analyze the usage of executeWithTimeout as you have suggested.

Also, had few observations related to the interface of EtcdProcessCluster in 3.5 vis-a-vis the main branch. The tests/e2e/v3_lease_no_proxy_test.go which needs to be backported references methods like WaitLeader and EndpointsGRPC which are not present in the 3.5 EtcdProcessCluster interface. Analyzing more on this.

Also, made minor change in EtcdProcessClusterConfig (tests/framework/e2e/cluster.go) in 3.5 to add the GoFailClientTimeout field used in tests/e2e/v3_lease_no_proxy_test.go.

[ahrtr]

The tests/e2e/v3_lease_no_proxy_test.go which needs to be backported references methods like WaitLeader and EndpointsGRPC which are not present in the 3.5 EtcdProcessCluster interface. Analyzing more on this.

Suggest to backport them as well, in this PR in a separate PR.

[amit-rastogi]

The tests/e2e/v3_lease_no_proxy_test.go which needs to be backported references methods like WaitLeader and EndpointsGRPC which are not present in the 3.5 EtcdProcessCluster interface. Analyzing more on this.

Suggest to backport them as well, in this PR in a separate PR.

Thanks @ahrtr. I'll create a separate PR for that.