chore(examples): remove rotted legacy example/MnistExperiment (#235)#249
Merged
Conversation
example/ (singular) was added to the build unconditionally but no CI job ever compiled it, so it drifted against the current factory layer-init API and no longer builds (cmake --build --preset examples on the default 'all' target fails). Delete it: examples/ (plural) is the canonical example location, and UnitTestMnistSmoke keeps MNIST end-to-end coverage in CI. Also switch the clang-format gate (ci.yml + its devenv.nix mirror) from the now-deleted 'example' to 'examples'. This removes the dangling find path and closes the pre-existing blind spot where the plural examples' C files were never format-checked (verified all currently clean). Closes #235 Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This was referenced Jun 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Deletes the legacy
example/(singular) directory — the standaloneMnistExperiment.ctrainer — and points the clang-format CI gate atexamples/(plural).Why
example/was added to the build unconditionally (add_subdirectory(example)), but no CI job ever compiled it:unit_test*build presets targetall_unit_tests, never the defaultall.--target train_c_*_v2.So it rotted invisibly against the factory layer-init refactor and no longer compiles —
linearLayerInit/reluLayerInitnow takelinearInit_t/layerQuant_t, with the old forms renamed*Legacy.cmake --build --preset exampleson the defaultalltarget fails; that is #235.MNIST coverage is unaffected:
examples/(plural) is the canonical example location, andUnitTestMnistSmokekeeps MNIST end-to-end coverage in CI.Also
The clang-format gate globbed
find src test examplein bothci.ymland itsdevenv.nixmirror. Withexample/gone that path would dangle, so it is switched toexamples— which also closes a pre-existing blind spot: the plural examples' C files were never format-checked. Verified all currently clean.Verification (local, macOS)
cmake --build --preset examples(defaultall) — now succeeds (was the examples: legacy example/MnistExperiment.c no longer compiles (stale layer-init API, CI-invisible) #235 reproducer)find src test examples … clang-format --dry-run -Werror— passesctest -L unit— 62/62 passASan / UBSan / pytest left to CI — unaffected by this change (macOS ASan init hangs locally).
Closes #235
🤖 Generated with Claude Code