ci(examples): build full 'all' target in bit-parity job (rot guard)#252
Merged
Conversation
…guard) The bit-parity job built only the two named example targets, so any other example executable was never compiled in CI - exactly how example/MnistExperiment (#235) and the legacy v1 trainers rotted unnoticed. Build the default 'all' target instead; a future example that fails to compile now fails CI. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Makes the CI
c-bit-parityjob build the examples preset's defaultalltarget instead of only the two named example binaries.Why
The job built only
--target train_c_har_classifier+--target train_c_ecg_anomaly_ae, so any other example executable was never compiled in CI. That is exactly howexample/MnistExperiment(#235) and the legacy v1 trainers rotted against API changes unnoticed — nothing built them. Buildingallmeans any example that fails to compile now fails CI.Note
Rot-guard completing the examples-cleanup series (#249 delete legacy, #250 Issue C init, #251 v1/v2 consolidation). Compilation needs no data, so it runs before the data-dependent bit-parity steps with no extra setup.
🤖 Generated with Claude Code