Skip to content

Build health: remove dead test seam (solution to 0 warnings) #1151

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
erikdarlingdata merged 1 commit into from
Jun 19, 2026
+1 −2
Merged

Build health: remove dead test seam (solution to 0 warnings) #1151

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions Dashboard.Tests/RemediationTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1943,7 +1943,6 @@ private sealed class FakeExecutor : IRemediationExecutor
public bool AuditWriteResult = true;
public Func<string, long, long, TargetPreflight>? PreflightFunc;
public Func<string, long, long, ForcePlanOutcome>? ForceFunc;
public Func<string, long, long, ForcePlanOutcome>? UnforceFunc;

public int ForceCalls;
public int UnforceCalls;
Expand Down Expand Up @@ -1974,7 +1973,7 @@ public Task<ForcePlanOutcome> ForcePlanAsync(string database, long queryId, long
public Task<ForcePlanOutcome> UnforcePlanAsync(string database, long queryId, long planId, RemediationIdentity identity, CancellationToken ct)
{
UnforceCalls++;
return Task.FromResult(UnforceFunc?.Invoke(database, queryId, planId) ?? new ForcePlanOutcome
return Task.FromResult(new ForcePlanOutcome
{
Database = database, QueryId = queryId, PlanId = planId,
Status = RemediationStatus.Success, Forced = true, ExecutingLogin = "sa", GateSpid = 55, ExecSpid = 55
Expand Down
Loading