Build health: remove dead test seam (solution to 0 warnings)#1151
Merged
Conversation
The only build warning across the solution: UnforceFunc was read in UnforcePlanAsync but never assigned by any test, so it was always null (CS0649). Removed the field and its no-op invoke; UnforcePlanAsync returns the same default outcome as before. Solution now builds at 0 warnings. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Quarterly build-health pass. The only warning across the whole solution was a
CS0649inDashboard.Tests—FakeExecutor.UnforceFuncwas read but never assigned by any test (always null). Removed the dead field + its no-op invoke;UnforcePlanAsyncreturns the same default outcome. Solution now builds at 0 warnings.Part of a dependency/build-health maintenance sweep:
vpkpinned (Bump Velopack 0.0.1298 → 1.2.0 and pin the vpk CLI to match #1150)..gitattributesline-ending normalization recommended as a separate, dedicated change since it renormalizes the whole repo.)Verification: Dashboard.Tests 487 green; 0 warnings.
🤖 Generated with Claude Code