Audit 1/3: production - the fixes that run on the pump - #25
Draft
enoch85 wants to merge 1 commit into
Draft
Annotations
12 warnings
|
Complete job
Node.js 20 is deprecated. The following actions target Node.js 20 but are being forced to run on Node.js 24: actions/checkout@v4, actions/setup-python@v5. For more information see: https://github.blog/changelog/2025-09-19-deprecation-of-node-20-on-github-actions-runners/
|
|
HACS validation
The repository does not contain brands assets at custom_components/effektguard/brand/icon.png. Falling back to checking the brands repository.
|
|
Run pytest:
custom_components/effektguard/__init__.py#L621
coroutine 'AsyncMockMixin._execute_mock_call' was never awaited
|
|
Run pytest:
custom_components/effektguard/__init__.py#L612
coroutine 'AsyncMockMixin._execute_mock_call' was never awaited
|
|
Run pytest:
custom_components/effektguard/__init__.py#L603
coroutine 'AsyncMockMixin._execute_mock_call' was never awaited
|
|
Run pytest:
custom_components/effektguard/__init__.py#L639
coroutine 'AsyncMockMixin._execute_mock_call' was never awaited
|
|
Run pytest:
custom_components/effektguard/__init__.py#L630
coroutine 'AsyncMockMixin._execute_mock_call' was never awaited
|
|
Run pytest:
custom_components/effektguard/__init__.py#L621
coroutine 'AsyncMockMixin._execute_mock_call' was never awaited
|
|
Run pytest:
custom_components/effektguard/__init__.py#L612
coroutine 'AsyncMockMixin._execute_mock_call' was never awaited
|
|
Run pytest:
custom_components/effektguard/__init__.py#L603
coroutine 'AsyncMockMixin._execute_mock_call' was never awaited
|
|
Run pytest:
tests/test_regression_imports.py#L965
Found 2 potential magic numbers:
optimization/dhw_optimizer.py:2131: Hardcoded DM threshold -500 (should be constant)
models/nibe/f750.py:171: Hardcoded DM threshold -400 (should be constant)
(Showing first 15 of potentially more)
|
|
Run pytest:
tests/test_regression_imports.py#L761
Found 23 unused constants out of 469 total:
- ATTR_TARGET_TEMP = 'target_temp'
- BILLING_PERIODS_PER_DAY = 24
- COMFORT_DEAD_ZONE = 0.2
- COMPRESSOR_COOL_DOWN_MINUTES = 15
- COMPRESSOR_RAMP_UP_MINUTES = 30
- CONF_DHW_CHARGING_TEMP_ENTITY = 'dhw_charging_temp_entity'
- CONF_DHW_TEMP_ENTITY = 'dhw_temp_entity'
- CONF_ENABLE_WEATHER_COMPENSATION = 'enable_weather_compensation'
- CONF_INDOOR_TEMP_ENTITY = 'indoor_temp_entity'
- CONF_OUTDOOR_TEMP_ENTITY = 'outdoor_temp_entity'
- CONF_RETURN_TEMP_ENTITY = 'return_temp_entity'
- CONF_SUPPLY_TEMP_ENTITY = 'supply_temp_entity'
- DAYTIME_END_QUARTER = 87
- DAYTIME_START_QUARTER = 24
- DHW_HEATING_TIME_HOURS = 1.5
- DHW_MIN_TEMP = 40.0
- DHW_SCHEDULING_WINDOW_MIN = 0.25
- DHW_URGENT_RUNTIME_MINUTES = 90
- DM_CRITICAL_T1_PEAK_AWARE_OFFSET = 0.5
- DM_CRITICAL_T2_PEAK_AWARE_OFFSET = 0.75
- DM_CRITICAL_T3_PEAK_AWARE_OFFSET = 1.0
- INDOOR_TEMP_RECOVERY_MAX_HOURS = 6.0
- NIBE_DEFAULT_SUPPLY_TEMP = 35.0
These constants are defined but never used in the codebase.
Consider removing them or verify they should be used.
|
background
wait
wait-all
cancel
parallel
Loading