FieldValue type - #35
Closed
oliverpool wants to merge 1 commit into
Closed
Conversation
This was referenced Oct 23, 2024
Contributor
Author
|
I can confirm that this helps a bit with emersion/go-webdav#173 (conformance test for carddav server) |
oliverpool
force-pushed
the
field_value
branch
from
October 23, 2024 18:27
07e5b7b to
deb971e
Compare
oliverpool
force-pushed
the
field_value
branch
from
October 24, 2024 19:55
2847935 to
ae7038e
Compare
Closed
Co-authored-by: GorthMohogany <lugo.mark@gmail.com>
oliverpool
force-pushed
the
field_value
branch
from
October 25, 2024 06:39
ae7038e to
d565c18
Compare
Contributor
Author
|
FYI I am giving a try to a larger refactoring in a dedicated package (loose fork): https://code.pfad.fr/gopim/vcard/ Main differences for users:
|
Owner
|
I'm not a fan of this approach in general. If there is no way around it, would prefer some dedicated getter/setter, just like we have for other data types. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Supersedes #11 and #34. Resolves #5 and #26
This is a breaking change
This changes the
stringtype from theField.Valueto a dedicatedFieldValuetype (backed by astring):Users who want the raw value, can call
FieldValue.String(). To get escaped values, callFieldValue.Values().