adds support for properties with multiple values - #34
Closed
oliverpool wants to merge 1 commit into
Closed
Conversation
Co-authored-by: GorthMohogany <lugo.mark@gmail.com>
Contributor
Author
|
Actually, I am wondering if we shouldn't let the comma as-is (i.e. no escaping / no unescaping): the application should interpret them how they like (and this lib should make it easy to escape them) |
Closed
Contributor
Author
|
Superseded by #35 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Continuing the work started by @GorthMohogany in #11 to address #5
When decoding, it splits the value if it contains unescaped
,From the original PR I dropped the space removal (
strings.TrimSpace(value)) since I couldn't find anything in the RFC supporting this operation.Note that it raises further questions for fields containing unescaped commas, like in https://datatracker.ietf.org/doc/html/rfc6350#section-8 (however those can be addressed in a later PR)