Skip to content

Announce checked/unchecked state for user rows in invite screen #7136

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
bmarty wants to merge 1 commit into
base: develop
Choose a base branch
from
+4 −4
Open

Announce checked/unchecked state for user rows in invite screen #7136

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions ...xui/src/main/kotlin/io/element/android/libraries/matrix/ui/components/CheckableUserRow.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,12 +8,12 @@

package io.element.android.libraries.matrix.ui.components

import androidx.compose.foundation.clickable
import androidx.compose.foundation.layout.Column
import androidx.compose.foundation.layout.Row
import androidx.compose.foundation.layout.Spacer
import androidx.compose.foundation.layout.fillMaxWidth
import androidx.compose.foundation.layout.width
import androidx.compose.foundation.selection.toggleable
import androidx.compose.runtime.Composable
import androidx.compose.runtime.Immutable
import androidx.compose.ui.Alignment
Expand All @@ -39,8 +39,8 @@ fun CheckableUserRow(
Row(
modifier = modifier
.fillMaxWidth()
.clickable(role = Role.Checkbox, enabled = enabled) {
onCheckedChange(!checked)
.toggleable(value = checked, role = Role.Checkbox, enabled = enabled) {
onCheckedChange(it)
},
verticalAlignment = Alignment.CenterVertically,
) {
Expand All @@ -65,7 +65,7 @@ fun CheckableUserRow(
}
}
Checkbox(
onCheckedChange = onCheckedChange,
onCheckedChange = null,
checked = checked,
enabled = enabled,
)
Expand Down
Loading