Skip to content

Announce checked/unchecked state for user rows in invite screen#7136

Open
bmarty wants to merge 1 commit into
developfrom
fix/a11y-invite-people
Open

Announce checked/unchecked state for user rows in invite screen#7136
bmarty wants to merge 1 commit into
developfrom
fix/a11y-invite-people

Conversation

@bmarty

@bmarty bmarty commented Jul 1, 2026

Copy link
Copy Markdown
Member

Summary

  • Replaces .clickable(role = Role.Checkbox) with .toggleable(value = checked, role = Role.Checkbox) in CheckableUserRow so TalkBack announces the current checked state and state changes (fixes A11y: [Invite people] Screen reader does not announce updated state when... #6407)
  • Sets Checkbox.onCheckedChange = null to make the inner checkbox a purely visual indicator, avoiding duplicate TalkBack focus on the same control

Test plan

  • Open the Invite People screen with TalkBack
  • Focus a user row — verify TalkBack announces "checked" or "unchecked"
  • Tap to toggle — verify TalkBack announces the state change

…ows (#6407)

Replace clickable(role = Role.Checkbox) with toggleable(value = checked, role =
Role.Checkbox) so TalkBack can announce the current state and state changes.
Set the inner Checkbox.onCheckedChange = null to make it a purely visual
indicator, avoiding duplicate accessibility focus on the same control.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
@bmarty bmarty requested a review from a team as a code owner July 1, 2026 16:05
@bmarty bmarty added the PR-Bugfix For bug fix label Jul 1, 2026
@bmarty bmarty requested review from ganfra and removed request for a team July 1, 2026 16:05
@bmarty bmarty marked this pull request as draft July 1, 2026 16:06
@sonarqubecloud

sonarqubecloud Bot commented Jul 1, 2026

Copy link
Copy Markdown

@github-actions

github-actions Bot commented Jul 1, 2026

Copy link
Copy Markdown
Contributor

📱 Scan the QR code below to install the build (arm64 only) for this PR.
QR code
If you can't scan the QR code you can install the build via this link: https://i.diawi.com/EfxdVi

@codecov

codecov Bot commented Jul 1, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 66.66667% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 80.54%. Comparing base (58b3830) to head (26e4e89).
⚠️ Report is 100 commits behind head on develop.

Files with missing lines Patch % Lines
...libraries/matrix/ui/components/CheckableUserRow.kt 66.66% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #7136   +/-   ##
========================================
  Coverage    80.54%   80.54%           
========================================
  Files         2689     2689           
  Lines        76433    76433           
  Branches     10291    10291           
========================================
  Hits         61566    61566           
  Misses       10933    10933           
  Partials      3934     3934           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@bmarty bmarty left a comment

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I confirm that this still works as expected with this change, hence the previous code was not as the issue description. The check state was read out loud.

@bmarty bmarty marked this pull request as ready for review July 2, 2026 09:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

PR-Bugfix For bug fix

Projects

None yet

Development

Successfully merging this pull request may close these issues.

A11y: [Invite people] Screen reader does not announce updated state when...

1 participant