Generate C# language examples via the .NET request converter#6509
Open
flobernd wants to merge 1 commit into
Open
Generate C# language examples via the .NET request converter#6509flobernd wants to merge 1 commit into
flobernd wants to merge 1 commit into
Conversation
flobernd
force-pushed
the
csharp-language-examples
branch
from
July 23, 2026 09:25
dd1d03d to
ba63461
Compare
flobernd
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Wires C# into the language-examples generation, side by side with Python, JavaScript, Ruby, PHP, curl, and Java.
docs/examples/generate-language-examples.jsconverts request examples to C# through@elastic/request-converter's newcsharpformat (elastic/request-converter#107), backed by the@elastic/request-converter-dotnetWASM bundle (elastic/elasticsearch-net#8931). The regeneratedlanguageExamples.jsonis deliberately not part of this PR; the C# entries land in a follow-up once the converter packages are published.Changes
'C#'added toLANGUAGES. C# conversion is best-effort: a failed conversion skips that example's C# entry and is reported in an end-of-run summary instead of aborting, because the .NET converter has known endpoint coverage gaps. The other languages keep their fail-fast behavior.@elastic/request-converter-dotnet(~9.5.0) added todocs/examples/package.json; the Makefile'sgenerate-language-examplestarget updates it together with@elastic/request-converter.Notes
languageExamples.json: thegenerate.ymlworkflow rebuildsoutput/but never runsgenerate-language-examples, which remains a manual Makefile target. A full local dry run against locally built converter packages converted 649 of 761 request examples (112 skipped: 96 unsupported endpoints, 16 conversion issues); generated examples use fluent descriptor syntax with an illustrativeMyDocumentdocument type.package-lock.jsonis intentionally untouched: the dotnet package is published from Add CI and npm packaging for the request converter elasticsearch-net#8931, and the lockfile refresh must follow the first publish.