Add CI and npm packaging for the request converter#8931
Merged
Conversation
…est-converter workflows The npm publish workflow's Assemble package step recorded $GITHUB_SHA instead of the commit actually checked out from the operator-chosen branch, and its git describe fallback for CLIENT_VERSION always failed because actions/checkout@v4 doesn't fetch tags by default. Add a Resolve commit step reading git rev-parse HEAD after checkout, and fetch-depth: 0 / fetch-tags: true so the fallback works for dispatch runs. Also add global-json-file to every setup-dotnet step in both workflows to match the SDK pin used elsewhere in the repo, and route the untrusted branch/tag event values through step env vars instead of interpolating them directly into run: script bodies.
This was referenced Jul 24, 2026
Contributor
💚 All backports created successfully
Questions ?Please refer to the Backport tool documentation and see the Github Action logs for details |
flobernd
added a commit
that referenced
this pull request
Jul 24, 2026
flobernd
added a commit
that referenced
this pull request
Jul 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Makes the
RequestConvertersolution CI-gated and publishable: a path-filtered workflow builds and testsRequestConverter.slnon converter-relevant changes, new packaging scripts assemble the WASM AppBundle into the@elastic/request-converter-dotnetnpm package, and a publish workflow ships that package with npm trusted publishing.Intention
The .NET request converter is being integrated into
@elastic/request-converteras a first-class C# exporter (elastic/request-converter#107), which generates the C# language examples in elasticsearch-specification (elastic/elasticsearch-specification#6509). Both consume the WASM bundle as an npm package. Because the bundle compiles the entire client in, each minor branch needs its own package version to produce valid examples for that stack version: the package version tracks the branch major.minor with a freely incrementing patch, and the exact embedded client version and commit are recorded in package.json metadata.Changes
dotnet test RequestConverter.slnworks without extra properties.src/RequestConverter.Wasm/npm/: package template, assembly script, Node smoke test, package README..github/workflows/request-converter.yml: build and test on pull requests and pushes, path-filtered to converter-relevant inputs (including the client sources the converter compiles in)..github/workflows/request-converter-npm-publish.yml: publishes the npm package on client releases and via manual dispatch, with provenance.Notes
@elasticnpm org must configure trusted publishing for@elastic/request-converter-dotnettargetingrequest-converter-npm-publish.ymlin this repo. The workflow upgrades npm at runtime because OIDC publishing requires npm 11.5.1 or newer.package.jsonrecords the exact built commit, so any drift from the tag is discoverable.major.minor(for exampleserverless-*) fail the publish workflow's branch guard by design.