Add GeoPoint shape type for geo_shape query#6413
Open
m15flores wants to merge 3 commits into
Open
Conversation
Contributor
|
Thanks @m15flores! Couple things: while this is not breaking for the java client, it could be for other clients that don't override to JsonData, so I'll have to check before merging; also, could you add a comment about this being a hackfix? |
Contributor
Author
|
Hey! Added the hackfix comment. Let me know if there's anything I can help verify for the other clients. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes elastic/elasticsearch-java#501
Adds a
GeoPointtype in_types/Geo.ts, following the same shape as the existingGeoLine, and references it fromGeoShapeFieldQuery.shapeasGeoShape | GeoPoint.Tried adding
GeoPointstandalone first (likeGeoLine), but it gets dropped as a dangling type since nothing points to it (GeoLineonly survives through the aggregation reference). ReferencingGeoPointfromshapefixes that without changingGeoShapeitself, so this isn't a breaking change: raw JSON shapes still work exactly as before,GeoPointis just an additional typed option.Tested against a live 8.15.0 cluster: querying a geo_shape field with
{"type": "point", "coordinates": [...]}as the shape returns the expected results.