Builtin GeoPoint shape

[ozcanyus]

Description

Hi.

It is not possible to build a geo_shape query with the type of point with existing shape and query builders in elastic java client v8.6.0. There is GeoLine shape but it requires multiple lists of coordinates.

Desired search request is:

"geo_shape": {
  "field_name": {
    "shape": {
      "type": "point",
      "coordinates": [
        29.0,
        40.0
      ]
    }
  }
}

It can be achieved with a custom GeoPoint shape class but I think it would be nice to have it along with the GeoLine in the client api.

[m15flores]

Dug into this one too.

GeoLine isn't actually wired into geo_shape, it's only referenced from the geo_line aggregation. People are borrowing it as a convenient JsonpSerializable via JsonData.of(...), since shape on GeoShapeFieldQuery is untyped (GeoShape = UserDefinedValue in the spec). This thread shows someone doing exactly that: thread

I tried adding a GeoPoint class following that pattern, but it gets dropped from the generated output entirely. Nothing points to it, so it's flagged as a dangling type. GeoLine only avoids that because the aggregation references it.

Properly fixing this would mean modeling shape as a union of all the GeoJSON variants (Point, LineString, Polygon, MultiPoint, etc, plus the envelope extension and WKT strings), which is a much bigger job than this issue seems to be asking for. And GeoShape/UserDefinedValue likely gets reused elsewhere too, so touching it isn't free.

Given that, would it make sense to just add GeoPoint following the same dangling-but-usable-via-JsonData pattern GeoLine has? It fixes the DX problem from this issue without the bigger redesign. The bigger union-typing work could be a separate issue if you think it's worth tracking.

[l-trotta]

Hey @m15flores, yeah that's the problem with this issue: actually fixing it would cause a significant breaking change, and adding a dangling GeoPoint would be a bit of a hackfix. Considering there's a workaround, I'd wait for the next major version to fix this, which could take... a long time before release :) but if you want you can create a specification PR with the fix in the meantime.

[m15flores]

Alright, thanks for the context. I'll go ahead with the GeoPoint hackfix PR then

[m15flores]

Opened elastic/elasticsearch-specification#6413 with the GeoPoint fix.