Fix errors associated with ctCheck when one cell type passes QC - #299
Open
sof202 wants to merge 3 commits into
Open
Fix errors associated with ctCheck when one cell type passes QC#299sof202 wants to merge 3 commits into
sof202 wants to merge 3 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This pull request will fix the crash that occurs when the
pairs()plotting function is called inctCheck.rmdwhen only one cell type passes QC (requires >1 column in the matrix used). In the event that only one cell type passes QC, a message will be sent to the error file.Small problem
The method in which the program determines that only one cell type passes QC is not the best. It specifically is checking if
mahDistPCAhas only one column (as this is what breaks thepairs()function call). However, this isn't very readable as the test isn't testing the source of the problem (only one cell type), but a consequence of it (mahDistPCAonly has one column). This should be refactored at some point, but I have no idea what is happening in these files.Issue ticket number
This pull request is to address issue: #290.
Type of pull request
Checklist