Skip to content

Fix errors associated with ctCheck when one cell type passes QC - #299

Open
sof202 wants to merge 3 commits into
masterfrom
fix-ctCheck-with-one-cell-type
Open

Fix errors associated with ctCheck when one cell type passes QC#299
sof202 wants to merge 3 commits into
masterfrom
fix-ctCheck-with-one-cell-type

Conversation

@sof202

@sof202 sof202 commented Feb 20, 2025

Copy link
Copy Markdown
Collaborator

Description

This pull request will fix the crash that occurs when the pairs() plotting function is called in ctCheck.rmd when only one cell type passes QC (requires >1 column in the matrix used). In the event that only one cell type passes QC, a message will be sent to the error file.

Small problem

The method in which the program determines that only one cell type passes QC is not the best. It specifically is checking if mahDistPCA has only one column (as this is what breaks the pairs() function call). However, this isn't very readable as the test isn't testing the source of the problem (only one cell type), but a consequence of it (mahDistPCA only has one column). This should be refactored at some point, but I have no idea what is happening in these files.

Issue ticket number

This pull request is to address issue: #290.

Type of pull request

  • Bug fix
  • New feature/enhancement
  • Code refactor
  • Documentation update

Checklist

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have tested my code to check that it is functional
  • I have used linters to check for common sources of errors
  • I have implemented fail safes in my code to account for edge cases
  • I have made the corresponding changes to the documentation

@sof202 sof202 added the bug Something isn't working label Feb 20, 2025
@sof202
sof202 requested a review from ew367 February 20, 2025 12:27
@sof202 sof202 linked an issue Feb 20, 2025 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: Failing to run ctCheck.rmd in DNA methylation QC pipeline

1 participant