Skip to content

refactor: Quieten library loads - #297

Open
sof202 wants to merge 3 commits into
masterfrom
quieten-library-loads
Open

refactor: Quieten library loads#297
sof202 wants to merge 3 commits into
masterfrom
quieten-library-loads

Conversation

@sof202

@sof202 sof202 commented Feb 20, 2025

Copy link
Copy Markdown
Collaborator

Description

This pull request will suppress all package start-up messages that are annoyingly sent to the standard error stream in the DNAm preprocessing(QC) pipeline. It's annoying that these messages get sent to the standard error stream as the error logs from running the pipeline are next to useless because of it (hundreds of lines of basically useless information, making it hard to find the actual error). If library loading is useful to someone that uses these scripts, then we can always change this so that library() calls print to the standard output stream instead.

I also noticed that a package was never being used, so I removed its loading (slight performance gain).

Issue ticket number

This pull request is to address issue: #294.

Type of pull request

  • Bug fix
  • New feature/enhancement
  • Code refactor
  • Documentation update

Checklist

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have tested my code to check that it is functional
  • I have used linters to check for common sources of errors
  • I have implemented fail safes in my code to account for edge cases
  • I have made the corresponding changes to the documentation

Removing clogging of error files
These were here before and were picked up by the regex pattern
@sof202 sof202 added refactor Code refactor needs reviewer the pull request needs to be assigned to a reviewer labels Feb 20, 2025
@sof202 sof202 linked an issue Feb 20, 2025 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

needs reviewer the pull request needs to be assigned to a reviewer refactor Code refactor

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: Library loading is not 100% quiet

1 participant