Skip to content

fix: remove Sentrix_ID/Position if all values are the same - #289

Open
sof202 wants to merge 1 commit into
masterfrom
fix-contrast-issue-with-sentrix-variables
Open

fix: remove Sentrix_ID/Position if all values are the same#289
sof202 wants to merge 1 commit into
masterfrom
fix-contrast-issue-with-sentrix-variables

Conversation

@sof202

@sof202 sof202 commented Feb 3, 2025

Copy link
Copy Markdown
Collaborator

Description

This fixes the case where the linear regression model fails due to all samples having the same Senrtix ID or same Sentrix Position.

In the event that all samples have a unique ID or unique Position, these variables will continue to be removed. An option in the future may be added that allows this case to be ignored. We remove such variables currently as resultant plots can have so many lines such that it is incredibly hard to interpret (especially when you have lots of samples)

Issue ticket number

This pull request is to address issue: #288 .

Type of pull request

  • Bug fix
  • New feature/enhancement
  • Code refactor
  • Documentation update

Checklist

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have tested my code to check that it is functional
  • I have used linters to check for common sources of errors
  • I have implemented fail safes in my code to account for edge cases
  • I have made the corresponding changes to the documentation

This fixes the case where the linear regression model fails due to all
samples having the same Senrtix ID or same Sentrix Position.

In the event that all samples have a unique ID or unique Position, these
variables will continue to be removed. An option in the future may be
added that allows this case to be ignored. We remove such variables
currently as resultant plots can have so many lines such that it is
incredibly hard to interpret (especially when you have lots of samples)
@sof202 sof202 added bug Something isn't working needs reviewer the pull request needs to be assigned to a reviewer labels Feb 3, 2025
@sof202 sof202 linked an issue Feb 3, 2025 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working needs reviewer the pull request needs to be assigned to a reviewer

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: Generating plots failing in DNA methylation QC

1 participant