-
Notifications
You must be signed in to change notification settings - Fork 53
feat: support command line pass in esbuild configuration #89
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
seho-dev
wants to merge
2
commits into
egoist:dev
Choose a base branch
from
seho-dev:dev
base: dev
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,3 +1,46 @@ | ||
| const ESBUILD_CONFIG_NAME = '--esbuild-config' | ||
|
|
||
| // parse process.argv.slice(2) and return an object | ||
| const parseArgs = (argv) => { | ||
| const args = {} | ||
| argv.forEach(arg => { | ||
| const index = arg.indexOf('=') | ||
| if (index !== -1) { | ||
| const key = arg.slice(0, index) | ||
| const value = arg.slice(index + 1) | ||
| args[key] = value | ||
| } | ||
| }) | ||
| return args | ||
| } | ||
|
|
||
| const args = parseArgs(process.argv.slice(2)); | ||
|
|
||
| // Determine if a string is json | ||
| const isJson = (str) => { | ||
| let result; | ||
| try { | ||
| result = JSON.parse(str); | ||
| } catch (e) { | ||
| return false; | ||
| } | ||
| if (typeof result !== 'object' || Array.isArray(result) || result === null) { | ||
| return false; | ||
| } | ||
| return result; | ||
| } | ||
|
|
||
| let isJsonConfig; | ||
|
|
||
| if (typeof args[ESBUILD_CONFIG_NAME] === 'string') { | ||
| isJsonConfig = isJson(args[ESBUILD_CONFIG_NAME]); | ||
| if (!isJsonConfig) { | ||
| // not json | ||
| console.log('esbuild-config is not json'); | ||
| } | ||
| } | ||
|
|
||
| require('./dist/node.js').register({ | ||
| target: `node${process.version.slice(1)}`, | ||
| ...(isJsonConfig || {}), | ||
| }) |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like this idea, but personally would prefer an option to specify a config-file that exports an object matching the esbuild config options.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok, I'll resubmit when I have time, thanks for the reply
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not the package author @seho-dev, so maybe wait to see if they agree with my person opinion :)