feat: support command line pass in esbuild configuration#89
Open
seho-dev wants to merge 2 commits into
Open
Conversation
|
|
Author
|
see #88 |
Author
ndelangen
reviewed
Feb 1, 2024
Comment on lines
+23
to
+27
| You can also pass a JSON string to specify configuration options for esbuild, such as if I want to pass in the banner configuration. | ||
|
|
||
| ```bash | ||
| node -r esbuild-register file.ts --esbuild-config="{\"banner\": \"console.log('is banner')\"}" | ||
| ``` |
There was a problem hiding this comment.
I like this idea, but personally would prefer an option to specify a config-file that exports an object matching the esbuild config options.
Author
There was a problem hiding this comment.
Ok, I'll resubmit when I have time, thanks for the reply
There was a problem hiding this comment.
I'm not the package author @seho-dev, so maybe wait to see if they agree with my person opinion :)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.