Skip to content

Skip notify-hooks completion sounds for subagents #7

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
itkonen wants to merge 1 commit into from
Closed

Skip notify-hooks completion sounds for subagents #7

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions plugins/notify-hooks/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ Desktop sound notifications for ECA events — never miss when ECA finishes or n

Two hooks that play system sounds:

- **`notify-finished`** — Plays a completion sound when ECA finishes responding (postRequest).
- **`notify-finished`** — Plays a completion sound when the primary ECA chat finishes responding (postRequest). Subagent completions are ignored when ECA provides `parent_chat_id`.
- **`notify-approval`** — Plays a notification sound when ECA needs tool call approval (preToolCall).

## Platform support
Expand All @@ -18,6 +18,6 @@ Two hooks that play system sounds:

- **Linux:** `sudo apt install libcanberra-gtk3-module` (Debian/Ubuntu) or equivalent
- **macOS:** No additional setup needed
- **`jq`** must be installed for the approval notification filter
- **`jq`** must be installed for notification filters

Credits: Based on the config shared by @ericdallo.
2 changes: 1 addition & 1 deletion plugins/notify-hooks/hooks/hooks.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
"actions": [
{
"type": "shell",
"shell": "jq -e '.hook_type == \"postRequest\"' > /dev/null && (canberra-gtk-play -i complete 2>/dev/null || afplay /System/Library/Sounds/Glass.aiff 2>/dev/null || true)"
"shell": "jq -e 'has(\"parent_chat_id\") | not' > /dev/null && (canberra-gtk-play -i complete 2>/dev/null || afplay /System/Library/Sounds/Glass.aiff 2>/dev/null || true)"
}
]
},
Expand Down