Skip notify-hooks completion sounds for subagents#7
Closed
itkonen wants to merge 1 commit into
Closed
Conversation
Filter finished notifications when ECA provides parent_chat_id so the plugin only plays completion sounds for primary chat completions. 🤖 Generated with [ECA](https://eca.dev) (openai/gpt-5.5 - high) Co-Authored-By: eca-agent <git@eca.dev>
Author
|
Closing this because editor-code-assistant/eca#508 was merged and solves the notify-hooks issue at the ECA hook-dispatch layer: That means notify-hooks no longer needs a |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
notify-finishedwhen ECA hook input containsparent_chat_id.parent_chat_idon subagentpostRequestpayloads.Follow-up to editor-code-assistant/eca#505.
🤖 Generated with ECA (openai/gpt-5.5 - high)