Skip to content

Asynchronously open internal browser for javadoc hover #3107

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
iloveeclipse merged 1 commit into from
Aug 7, 2026
+12 −2
Merged

Asynchronously open internal browser for javadoc hover #3107

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 11 additions & 1 deletion org.eclipse.jdt.ui/ui/org/eclipse/jdt/internal/ui/actions/OpenBrowserUtil.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@
public class OpenBrowserUtil {

/**
* Opens the given url in the browser as choosen in the preferences.
* Opens the given url in the browser as chosen in the preferences.
*
* @param url the URL
* @param display the display
Expand All @@ -39,6 +39,16 @@ public static void open(final URL url, Display display) {
display.syncExec(() -> internalOpen(url, false));
}

/**
* Asynchronously opens the given url in the browser as chosen in the preferences.
*
* @param url the URL
* @param display the display
*/
public static void openAsync(final URL url, Display display) {
display.asyncExec(() -> internalOpen(url, false));
}

/**
* Opens the given URL in an external browser.
*
Expand Down
2 changes: 1 addition & 1 deletion org.eclipse.jdt.ui/ui/org/eclipse/jdt/internal/ui/text/java/hover/JavadocHover.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -676,7 +676,7 @@ public boolean handleExternalLink(URL url, Display display) {
control.dispose(); //FIXME: should have protocol to hide, rather than dispose

// Open attached Javadoc links
OpenBrowserUtil.open(url, display);
OpenBrowserUtil.openAsync(url, display);

return true;
}
Expand Down
Loading