Asynchronously open internal browser for javadoc hover - #3107
Merged
iloveeclipse merged 1 commit intoAug 7, 2026
Merged
Conversation
r-mennig
force-pushed
the
open_javadoc_hover_external_link_async
branch
2 times, most recently
from
August 7, 2026 14:53
0244932 to
15f2805
Compare
Open internal browser asynchronously when handling external link in javadoc hover. This fixes a deadlock under Windows with its Edge/WebView2 browser runtime as it avoids the new browser instance being created from within the (navigation) callback of another browser instance. Fixes eclipse-jdt#3105
r-mennig
force-pushed
the
open_javadoc_hover_external_link_async
branch
from
August 7, 2026 14:54
15f2805 to
7cf6cef
Compare
HeikoKlare
approved these changes
Aug 7, 2026
HeikoKlare
left a comment
HeikoKlare
left a comment
Contributor
There was a problem hiding this comment.
I have tested the proposal with the scenario we have identified in #3105 as well as other navigation scenarios in the JavadocHover (navigating to other Javadoc pages, having an external browser preferred via prefereces). I have tested with Windows and macOS.
The change works fine for me on both systems and in all scenarios, and it particularly resolves the UI freeze issue on Windows.
It is also conceptually sound to me, as opening a browser view does not need to happen synchronous from a URL navigation callback inside a view but may reasonably be scheduled for asynchronous execution.
iloveeclipse
approved these changes
Aug 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, when opening an external link in a javadoc hover in the internal browser under Windows, the user interface permanently freezes.
This is caused by a deadlock within the Edge/WebView2 browser runtime which occurs if a new browser instance is being created from within a (navigation) callback of another browser instance.
Adapting
handleExternalLink(URL, Display)in the link handler used by theJavadocHoverto open the new browser instance asynchronously fixes the problem as the browser creation is now moved out of the (navigation) callback.Fixes #3105