fix: close streams and writers with try-with-resources#1390
Merged
joaodinissf merged 1 commit intoJun 1, 2026
Conversation
Several streams/writers were leaked on non-happy paths: - DeployJob: FileInputStream passed to EMF Resource.load (which does not close caller streams) - CheckExtensionGenerator: BufferedInputStream passed to SAXParser.parse - KeywordAnalysisHelper.printViolations / printReport: PrintWriters closed only on the happy path Wrap each in try-with-resources so they are always closed. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
rubenporras
approved these changes
Jun 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Several streams/writers were leaked on non-happy paths:
DeployJob—FileInputStreampassed to EMFResource.load(which doesn't close caller-supplied streams).CheckExtensionGenerator—BufferedInputStreampassed toSAXParser.parse.KeywordAnalysisHelper(printViolations/printReport) —PrintWriters closed only on the happy path.Each is wrapped in try-with-resources so it's always closed. (The two
IFile.getContents()sites inCheckTocGenerator/CheckContextsGeneratorare handled separately — theirthrows CoreExceptionmethods needIOException-from-close()handling.)Found by a repo-wide inconsistency sweep.
🤖 Generated with Claude Code