fix: close IFile.getContents() streams in Toc/Contexts generators#1393
Merged
joaodinissf merged 1 commit intoJun 1, 2026
Merged
Conversation
CheckTocGenerator.loadTocModel and CheckContextsGenerator.update/removeContexts passed file.getContents() straight to CoreUtility.getTextDocument and model.load, which do not close caller-supplied streams. Wrap each in try-with-resources; since these methods only declare CoreException, the close()-time IOException is caught and wrapped in a CoreException (same pattern as DeployJob in this module). Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
rubenporras
approved these changes
Jun 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CheckTocGenerator.loadTocModelandCheckContextsGenerator.updateContextsFile/removeContextspassedfile.getContents()straight toCoreUtility.getTextDocumentandmodel.load, neither of which closes a caller-supplied stream — leaking anInputStreamper call.Each is now wrapped in try-with-resources. Because these methods only declare
throws CoreException, theclose()-timeIOExceptionis caught and re-wrapped in aCoreExceptionusing the module's existing pattern (new Status(Status.ERROR, Activator.getPluginId(), …), as inDeployJob).Found by a repo-wide inconsistency sweep. (Split out from #1390; this one needed the extra
IOExceptionhandling.)🤖 Generated with Claude Code