This repository was archived by the owner on Jun 4, 2026. It is now read-only.
Update to Go 1.22, Alpine 3.20#38
Open
tianon wants to merge 3 commits into
Open
Conversation
This also embeds version numbers directly in the template so they're easier to maintain (since we're not scraping them from anywhere, `versions.json` doesn't add a lot of value here, just overhead). I chose Go 1.22 instead of 1.23 as a temporary measure because of https://go.dev/issues/68976 (and the potential of that to make this harder to test).
Contributor
Author
|
As noted in #36 (comment), there's a pretty comprehensive smoke test that happens as part of CI in this repository (both the basics, then the full upstream integration tests) which should make this pretty safe to merge, assuming that comes back clean. |
whalelines
approved these changes
Sep 9, 2024
whalelines
left a comment
whalelines
left a comment
There was a problem hiding this comment.
Looks like the generated Dockerfiles are not marked as generated properly.
If I understand your comments correctly, the testing in the repo should be sufficient to determine if updating Go, Debian, and Alpine will break notary.
ppand
approved these changes
Nov 20, 2024
|
Old golang modules stdlib:go1.19.6 has been flagged to have critical vulnerabilities. It will be good to have this PR merged sooner. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This also embeds version numbers directly in the template so they're easier to maintain (since we're not scraping them from anywhere,
versions.jsondoesn't add a lot of value here, just overhead).I chose Go 1.22 instead of 1.23 as a temporary measure because of golang/go#68976 (and the potential of that to make this harder to test).