This repository was archived by the owner on Jun 4, 2026. It is now read-only.
Bump Golang and Alpine version#36
Closed
LaurentGoderre wants to merge 1 commit into
Closed
Conversation
whalelines
reviewed
Aug 7, 2024
whalelines
left a comment
whalelines
left a comment
There was a problem hiding this comment.
Have the results of these changes been tested?
tianon-sso
approved these changes
Aug 7, 2024
Member
|
Yes, there's a smoke test in this repository that runs the full upstream test suite and some basic signing flows with Docker-in-Docker: https://github.com/docker/notary-official-images/blob/d1a94cf525b59aa7452a436d7cdc3d65f2a64fd8/.test/test.sh |
tianon
approved these changes
Aug 7, 2024
tianon
left a comment
tianon
left a comment
Contributor
There was a problem hiding this comment.
Approving here too, just in case this account has merge access 👀
Contributor
|
I've opened an updated alternative to this in #38 |
LaurentGoderre
force-pushed
the
alpine-golang-bump
branch
from
e055fba to
6fcd67e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.