Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions pyproject.toml
Original file line number Diff line number Diff line change
Expand Up @@ -102,6 +102,7 @@ ducklake = [
filesystem = [
"s3fs>=2022.4.0",
"botocore>=1.28",
"pandas>=2.3.0,<3",
]
s3 = [
"s3fs>=2022.4.0",
Expand Down
9 changes: 9 additions & 0 deletions tests/workspace/cli/test_init_command.py
Original file line number Diff line number Diff line change
Expand Up @@ -4,9 +4,11 @@
import hashlib
import os
import contextlib
from pathlib import Path
from subprocess import CalledProcessError
from typing import List, Tuple, Optional
import pytest
import tomlkit
from pytest_console_scripts import ScriptRunner
from unittest import mock
from pytest import MonkeyPatch
Expand Down Expand Up @@ -261,6 +263,13 @@ def test_init_command_core_source_requirements_with_extras(
assert canonical_name in source_requirements.dlt_requirement.extras


def test_filesystem_extra_installs_read_csv_dependency() -> None:
pyproject = tomlkit.parse(Path(__file__).parents[3].joinpath("pyproject.toml").read_text())
filesystem_deps = pyproject["project"]["optional-dependencies"]["filesystem"]

assert any(Requirement(dep).name == "pandas" for dep in filesystem_deps)


@pytest.mark.parametrize(
"source_name",
[name for name in CORE_SOURCES_CONFIG if not CORE_SOURCES_CONFIG[name]["requires_extra"]],
Expand Down