fix: include pandas in filesystem extra#4123
Open
fengjikui wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
filesystemoptional extra sodlt[filesystem]installs the dependency used bydlt.sources.filesystem.read_csvWhy
dlt init filesystem postgresgenerates requirements that rely on thefilesystemextra, but the filesystem example callsread_csv(), whose implementation imports pandas directly. Without pandas in the extra, users can install the generated requirements and still hit a missing dependency when running the example.Fixes #3876.
Validation
uv run --extra hub pytest tests/workspace/cli/test_init_command.py::test_filesystem_extra_installs_read_csv_dependency tests/workspace/cli/test_init_command.py::test_init_command_core_source_requirements_with_extras -q-> 3 passeduv run --extra filesystem python - <<'PY' ...confirmed editable metadata exposespandas<3,>=2.3.0; extra == 'filesystem'uv run python tools/check_dependency_changes.py origin/devel HEADreports the intended optional dependency addition:[filesystem]: + pandas<3,>=2.3.0