4153: Improve bottomSheet handle - #4274
Conversation
lunars97
left a comment
There was a problem hiding this comment.
Thank you for effort! Looks almost perfect 😻 , on iOS the arrow looks not that noticeable I would say, maybe we could highlight it a little bit by setting a light background color or making the arrow bolder 💭 (or all together?). Currently is looks like this on iOS:

what do you think, @ulyanahoy-cloud , about it?
a8b395c to
c2efdcc
Compare
2026-07-27.17-47-26.movAnd yes I tried to move the title of the selected place to behave like the nearby text but some titles are big that it will affect the size of the handle or by using ellipsis (...) that would hide part of the title so I abandoned that idea. |
882aa77 to
45443df
Compare
45443df to
dfc47a2
Compare
|
Looks really good! Maybe only the button animation could be a bit smoother, if that's possible. |
lunars97
left a comment
There was a problem hiding this comment.
Looks almost perfect, just left some improvement suggestions 😻
| const BottomActionSheet = ({ children, sibling, ref }: BottomActionSheetProps): ReactElement => { | ||
| const BottomActionSheet = ({ children, sibling, title, ref }: BottomActionSheetProps): ReactElement => { | ||
| const [scrollElement, setScrollElement] = useState<HTMLElement | null>(null) | ||
| const [isFullscreen, setIsFullscreen] = useState(false) |
There was a problem hiding this comment.
❌ This useState is redunant:
| const [isFullscreen, setIsFullscreen] = useState(false) | |
| const isFullscreen = bottomSheetRef.current?.height ?? 0) >= max |
There was a problem hiding this comment.
it wont re-render the arrow when it reaches fullscreen 🤔
lunars97
left a comment
There was a problem hiding this comment.
Tested on real android device, ios simulator and chrome with safari with keyboard and screen-reader. Looks almost perfect, just left some suggestions 👍
lunars97
left a comment
There was a problem hiding this comment.
LGTM! Not tested again 👍



Short Description
Improve the visibility and affordance of the bottom sheet by:
Proposed Changes
Native:
Handlestyling with a centeredPressablepadded16pxvertically.isFullscreenprop (defaultfalse) to flip the Chevron when the sheet reaches full screen.bottomSheetHandle.heightfrom40to56.HandlewithaccessibilityLabel={t('handle')}Web:
bottomSheetHandleHeightfrom40to56andmidSnapPercentagefrom0.35to0.5KeyboardArrowUpIconandKeyboardArrowDownIconfrom@mui/icons-material.isFullscreenstate afterscrollElementand anupdateFullscreenhandler wired toonSpringEndthat flips it when the sheet'sheightreaches themaxsnap point.[data-rsbs-header]padding-topfrom24pxto16pxso the handle icon centers vertically.content: noneto[data-rsbs-header]::beforeto hide the library's default handle.Side Effects
N/A
Checklist
Testing
Resolved Issues
Fixes: #4153