Skip to content

preview page flags if overlap detected in entiy organiisation csv - #172

Merged
pooleycodes merged 5 commits into
mainfrom
2765-for-single-source-datasets-allow-entity-organisation-to-be-entire-entity-range
Jul 13, 2026
Merged

preview page flags if overlap detected in entiy organiisation csv#172
pooleycodes merged 5 commits into
mainfrom
2765-for-single-source-datasets-allow-entity-organisation-to-be-entire-entity-range

Conversation

@pooleycodes

@pooleycodes pooleycodes commented Jul 7, 2026

Copy link
Copy Markdown
Contributor

What type of PR is this? (check all applicable)

  • Refactor
  • Feature
  • Bug Fix
  • Optimization
  • Documentation Update

Description

Updates the entity-organisation CSV preview to match the new overlap/error flags returned by the async-request-backend:

  • No new entities → entity-org section is hidden entirely.
  • Non-authoritative data → informational message shown (nothing needs to be created).
  • Overlap detected (entities already covered by an existing range) → informational banner "Entity org already exists - no action needed", table not shown.
  • Error loading entity-organisation.csv on the backend → error message shown, table not shown.
  • Otherwise → entity-organisation table renders as before.

Related Tickets & Documents

  • Ticket Link: 2765
  • Related Issue #
  • Closes #

QA Instructions, Screenshots, Recordings

Entity Organisation CSV in Preview:

  • No new entities = no render.
  • New entities = Renders entity org table as before
  • Overlap Detected =
image - Error in Creating/Accessing file =

Warning Message Flags instead

Added/updated tests?

We encourage you to keep the code coverage percentage at 80% and above. Please refer to the Digital Land Testing Guidance for more information.

  • Yes

[optional] Are there any post deployment tasks we need to perform?

None

[optional] Are there any dependencies on other PRs or Work?

Depends on digital-land/async-request-backend#124 for the overlap/error fields in the pipeline-summary response.

@coderabbitai

coderabbitai Bot commented Jul 7, 2026

Copy link
Copy Markdown

Warning

Review limit reached

@pooleycodes, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 25 minutes

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 259c1d32-5503-4d22-b2d6-f744987bc3fb

📥 Commits

Reviewing files that changed from the base of the PR and between f206eb9 and 853fec8.

📒 Files selected for processing (5)
  • application/blueprints/datamanager/controllers/preview.py
  • application/blueprints/datamanager/services/github-add.md
  • application/templates/datamanager/entities_preview.html
  • config/config.py
  • tests/unit/blueprints/datamanager/controllers/test_preview.py
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch 2765-for-single-source-datasets-allow-entity-organisation-to-be-entire-entity-range

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@pooleycodes
pooleycodes marked this pull request as ready for review July 9, 2026 14:32
gibahjoe
gibahjoe previously approved these changes Jul 13, 2026
…e-datasets-allow-entity-organisation-to-be-entire-entity-range

# Conflicts:
#	application/blueprints/datamanager/controllers/preview.py
#	config/config.py
@pooleycodes
pooleycodes merged commit f32ed84 into main Jul 13, 2026
3 checks passed
@pooleycodes
pooleycodes deleted the 2765-for-single-source-datasets-allow-entity-organisation-to-be-entire-entity-range branch July 13, 2026 14:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

For single-source datasets, allow entity-organisation to be entire entity range

2 participants