Skip to content

don't show expected 404 as logger error #134

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pooleycodes merged 1 commit into from
Jul 24, 2026
Merged

don't show expected 404 as logger error #134

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions request-processor/src/application/core/workflow.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -154,6 +154,14 @@ def download_file(url, destination):
) as response:
with open(destination, "wb") as f:
f.write(response.read())
except HTTPError as e:
# 404s are expected (e.g. branch-fallback / optional CSVs); let the
# caller decide severity. Log other HTTP errors as errors.
if e.code == 404:
logger.warning(f"Not found (may be expected) {url}: {e}")
else:
logger.error(f"Failed to download {url}: {e}")
raise
except (socket.timeout, URLError) as e:
logger.error(f"Failed to download {url}: {e}")
raise
Expand Down