Skip to content

don't show expected 404 as logger error - #134

Merged
pooleycodes merged 1 commit into
mainfrom
768-failed-to-download-httpsrawgithubusercontentcomdigital-landconfigrefsheadsconfig-manager-updatecollectionconservation-areaendpointcsv-http-error-404-not-found
Jul 24, 2026
Merged

don't show expected 404 as logger error#134
pooleycodes merged 1 commit into
mainfrom
768-failed-to-download-httpsrawgithubusercontentcomdigital-landconfigrefsheadsconfig-manager-updatecollectionconservation-areaendpointcsv-http-error-404-not-found

Conversation

@pooleycodes

@pooleycodes pooleycodes commented Jul 23, 2026

Copy link
Copy Markdown
Contributor

What type of PR is this? (check all applicable)

  • Refactor
  • Feature
  • Bug Fix
  • Optimization
  • Documentation Update

Description

Sentry was flagging an expected 404 as an error. The URL in the alert (config/refs/heads/config-manager-update/collection/conservation-area/endpoint.csv) comes from the branch-fallback path: we try the config-manager branch first and fall back to main if the file isn't there, so a 404 is normal and handled.

The noise came from download_file, where 404 errors were being logged at error before re-raising. So Sentry captured it even though the caller handled it gracefully.

Related Tickets & Documents

QA Instructions, Screenshots, Recordings

Please replace this line with instructions on how to test your changes, a note
on the devices and browsers this has been tested on, as well as any relevant
images for UI changes.

Added/updated tests?

We encourage you to keep the code coverage percentage at 80% and above. Please refer to the Digital Land Testing Guidance for more information.

  • Yes
  • No, and this is why: please replace this line with details on why tests
    have not been included
  • I need help with writing tests

[optional] Are there any post deployment tasks we need to perform?

[optional] Are there any dependencies on other PRs or Work?

@coderabbitai

coderabbitai Bot commented Jul 23, 2026

Copy link
Copy Markdown

Warning

Review limit reached

@pooleycodes, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 23 minutes

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 6e0ccbc6-ac6a-4eec-a282-ec1c38b4b28d

📥 Commits

Reviewing files that changed from the base of the PR and between 2741c6f and 77426f5.

📒 Files selected for processing (1)
  • request-processor/src/application/core/workflow.py
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch 768-failed-to-download-httpsrawgithubusercontentcomdigital-landconfigrefsheadsconfig-manager-updatecollectionconservation-areaendpointcsv-http-error-404-not-found

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@gibahjoe gibahjoe left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pooleycodes
pooleycodes merged commit 334f523 into main Jul 24, 2026
3 checks passed
@pooleycodes
pooleycodes deleted the 768-failed-to-download-httpsrawgithubusercontentcomdigital-landconfigrefsheadsconfig-manager-updatecollectionconservation-areaendpointcsv-http-error-404-not-found branch July 24, 2026 08:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

2 participants