docs(crossplane): correct stale org-ruleset adoption comment#2277
Merged
Conversation
The org-ruleset activation comment said "~19 UI-managed org rules ... adopted Observe-first" — but provider-upjet-github can faithfully express only 10 of the org's 20 org rulesets. Update it to the real split: 10 adopted Observe-first in devantler-tech/.github deploy/rulesets/ (+ a net-new tag ruleset); the other 10 (repository_property conditions, code_quality/copilot rules, repository-target), plus push rulesets and the new Actions workflow-execution-protections, aren't expressible and stay UI-managed (tracked in devantler-tech/.github#69). Comment-only; no resource/behaviour change. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Contributor
|
🎉 This PR is included in version 1.80.2 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Corrects a now-inaccurate comment in the github MRD activation policy. It claimed
"~19 UI-managed org rules … adopted Observe-first", but
provider-upjet-githubcanfaithfully express only 10 of the org's 20 org rulesets. The updated comment states
the real split (10 adopted Observe-first in
devantler-tech/.githubdeploy/rulesets/repository_propertyconditions,code_quality/copilot_code_reviewrules,repository-target — plus push rulesets andthe new Actions workflow-execution-protections stay UI-managed, tracked in
devantler-tech/.github#69).
Comment-only — no resource or behaviour change. Companion to the adoption PR
devantler-tech/.github#70.