feat: add dclenv support to launchDesktopApp deep link#441
Merged
Conversation
Add `dclenv` field to `JumpInOptions` and include it in the `decentraland://` URL built by `buildDecentralandUrl`. This lets callers forward the environment selection parameter (e.g. `zone`) so the Launcher opens the Explorer against the intended environment.
Deploying ui2 with
|
| Latest commit: |
8715064
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://5ac22d29.ui2-423.pages.dev |
| Branch Preview URL: | https://feat-dclenv-deep-link-suppor.ui2-423.pages.dev |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add
dclenvtoJumpInOptionsand forward it as a query parameter in thedecentraland://deep link built bybuildDecentralandUrl.This is a backward-compatible, additive change — existing callers that omit
dclenvsee no change in behavior.Why
decentraland.org/jumpURLs accept a?dclenv=parameter (e.g.?dclenv=zone) to let users open the Explorer in a specific environment. Without this change,launchDesktopAppdrops the parameter and the Launcher always opens the default (prod) environment, breaking QA and zone workflows.What changed
src/modules/jumpIn.tsdclenv?: stringfield toJumpInOptions(with JSDoc note)buildDecentralandUrlnow appendsdclenvto the URL params when presentDownstream
decentraland/siteshas a companion PR that reads?dclenv=from the jump URL and passes it tolaunchDesktopApp. That PR is self-contained — it does not require this one to be merged first (TypeScript structural subtyping allows the extra field). Once this PR is merged and a new version ofdecentraland-ui2is published, thesitesPR will fully activate the end-to-end behavior.Requested by Pravus via Slack