feat: forward dclenv param from jump URL into Explorer deep link#487
Merged
Conversation
Read the `dclenv` query parameter from the current URL in JumpInButton and pass it through buildDeepLinkOptions → launchDesktopApp so that URLs like /jump?realm=...&position=...&dclenv=zone open the Explorer in the correct environment.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Coverage Report for CI Build 26058979581Coverage increased (+0.01%) to 93.51%Details
Uncovered ChangesNo uncovered changes found. Coverage RegressionsNo coverage regressions found. Coverage Stats
💛 - Coveralls |
# Conflicts: # src/components/jump/JumpInButton/JumpInButton.spec.tsx
This reverts commit 91bd180.
braianj
approved these changes
May 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a user opens
decentraland.org/jump?realm=...&position=...&dclenv=zone, thedclenvparameter was silently dropped before callinglaunchDesktopApp, so the Launcher always opened the default (prod) Explorer regardless of the requested environment.What changed
src/features/places/places.helpers.tsbuildDeepLinkOptions(position, realm, dclenv?)gains a third optional argumentdclenvin the options object when providedsrc/components/jump/JumpInButton/JumpInButton.tsx?dclenv=from the current URL viauseSearchParamsbuildDeepLinkOptions→launchDesktopAppdclenvadded to theuseCallbackdependency arraysrc/features/places/places.helpers.spec.ts/JumpInButton.spec.tsxdclenvforwarding in both helper and buttonDependency
A companion PR in
decentraland/ui2addsdclenvtoJumpInOptionsandbuildDecentralandUrl: decentraland/ui2#441This PR is deployable independently (TypeScript structural subtyping allows passing
dclenvbeforeui2is updated). The end-to-enddclenvforwarding activates fully oncedecentraland-ui2is bumped to a version that includes theui2PR.Requested by Pravus via Slack