Skip to content

Fix a bunch of spelling mistakes#57

Merged
datdenkikniet merged 3 commits into
datdenkikniet:mainfrom
weriomat:spelling
Jul 12, 2026
Merged

Fix a bunch of spelling mistakes#57
datdenkikniet merged 3 commits into
datdenkikniet:mainfrom
weriomat:spelling

Conversation

@weriomat

Copy link
Copy Markdown
Contributor

This is more or less a drive by fix.
I was doing some spell checking of an upstream project siomon and noticed some spelling issues in the API (mainly Celcius should be Celsius).
The amazing typos spell checker was used in finding the mistakes ;)
If needed a GitHub action is available too.

This introduces user facing changes.

datdenkikniet
datdenkikniet previously approved these changes Jul 12, 2026

@datdenkikniet datdenkikniet left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, this is great. I'll add a CI check for it, too, that seems useful.

I've rebased on latest main and force-pushed to your branch (because I like linear history and intended to merge it right away), but realized that it drops the commit verification. Let me know if you'd prefer to re-commit as yourself to regain the commit verification, or if you are OK with me merging this as-is.

Are you up for adding a typos CI check as well? If not, I can do so, but let's coordinate so we don't do double work.

@weriomat

Copy link
Copy Markdown
Contributor Author

Hey, I can add the Ci checks to this PR

weriomat added 3 commits July 12, 2026 18:14
We added `Ba` to the ignored words as it is contained in `dBa` which is
correct.
@weriomat

Copy link
Copy Markdown
Contributor Author

Resigned commits and added Ci checks.
Note that Ba is added as an ignored word as it correctly used in ipmi-rs-core/src/storage/sdr/units.rs:186.

@weriomat
weriomat requested a review from datdenkikniet July 12, 2026 16:17
@datdenkikniet
datdenkikniet merged commit e8c14a3 into datdenkikniet:main Jul 12, 2026
33 checks passed
weriomat added a commit to weriomat/siomon that referenced this pull request Jul 13, 2026
I have fixed a bunch of spelling mistakes in
[ipmi-rs](datdenkikniet/ipmi-rs#57)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants