chore: apply clippy lints#58
Conversation
|
Ah, this is a good addition, thank you for the initiative! I realized that the CI is not stringent enough: it runs checks on all kinds of combinations, but is fine with any warnings (this PR introduces a single one: renaming the sometimes-unused Additionally, if you would add a I.e. - "-p ipmi-rs --no-default-features --examples"
steps:
- uses: actions/checkout@v5
- - name: Check a package with specific feature combination.
+ - name: cargo check a package with specific feature combination.
+ run: CARGO_BUILD_WARNINGS=deny cargo check --locked ${{ matrix.command }}
+ - name: cargo clippy a package with specific feature combination.
run: CARGO_BUILD_WARNINGS=deny cargo clippy --locked ${{ matrix.command }}
test: |
|
Rebased onto main |
|
Note that if I add CI checks this PR depends on #57 |
|
Added ci checks for clippy. |
|
Fixed typo in Ci |
There lints are a fix from the "normal" lints as well as the pedantic lints
According to the [documentation](https://doc.rust-lang.org/stable/clippy/continuous_integration/index.html#continuous-integration) `-Dwarnings` should be used in order for clippy to fail in case of errors. The documentation on using workspaces with clippy can be found [here](https://doc.rust-lang.org/stable/clippy/usage.html#workspaces). As the check phase does not use `--no-deps` flag it is neither used here which results in linting dependencies in addition to the crate itself (meaning the `ipmi-rs-core` crate gets linted multiple times).
|
Apparently I forgot to push the commit where I appended the fix (in the previous PR). |
|
Thanks! |
|
Any chance a new release can be made soon? |
|
Yes, now is as good a time as any! Release train on the way in #60 Edit: and now everything should be available through crates.io as well :) |
|
Thank you ! |
2 participants
There lints are a fix from the "normal" lints as well as the pedantic lints.
Please note that I did not fix all pedantic lints.