feat: Blog tab on the Feed engine — unified browse/search with view-owned paging - #234
Open
danieltmbr wants to merge 1 commit into
Open
feat: Blog tab on the Feed engine — unified browse/search with view-owned paging#234danieltmbr wants to merge 1 commit into
danieltmbr wants to merge 1 commit into
Conversation
…wned paging BlogTab becomes pure chrome; PostsList owns everything through one PostsQuery: the same inputs drive the local @query predicate (PostRecord.blog), the network fetch, and — as the task id — the re-fetch trigger on term/filter change. - fetch(page:) folds receipts into view-owned paging state: a failed page 1 clears it (no dead sessions), a failed next page keeps it so scrolling retries the same page - Row-driven frontier paging: rows at/past the fetched frontier pull the next page as they appear, so a warm cache re-validates while scrolling instead of only at the very bottom - Pull-to-refresh and load-more work in browse and search alike; fetches fire immediately (the model supersedes in-flight requests — no view debounce) - Languages are sent to the server (?languages=) instead of filtering only locally The old blog layer (BlogModel, actions, env keys) stays until its remaining consumers (QuotesTab piggyback, SearchTab) migrate in the next PR. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Stack 2/4 (on #233). BlogTab is the reference implementation of the Feed pattern.
PostsQuerydrives everything: the local@Querypredicate (PostRecord.blog), the network fetch, and — as the.taskid — the re-fetch trigger on term/filter changefetch(page:)foldsFeedPagereceipts in — failed page 1 clears (no dead sessions), failed next page keeps (scroll retries)Old blog layer stays until its last consumers (QuotesTab piggyback, SearchTab) migrate in the next PR.
Verification
swift test --package-path app-core— 65 tests green🤖 Generated with Claude Code