feat: Quotes tab + Search tab on the Feed engine; retire the blog layer - #235
Open
danieltmbr wants to merge 1 commit into
Open
feat: Quotes tab + Search tab on the Feed engine; retire the blog layer#235danieltmbr wants to merge 1 commit into
danieltmbr wants to merge 1 commit into
Conversation
QuotesList mirrors PostsList: one QuotesQuery drives the local @query predicate (QuoteRecord.quotes), the network fetch, and the re-fetch trigger; view-owned FeedPage paging state; row-driven frontier paging; pull-to-refresh and paging in browse and search alike. - Quote browse now feeds from GET /api/quotes directly (paged, server-filtered by languages + sources) — the catalogue/blog piggyback refresh is gone, and browse gains pagination - QuotesModel slims to the source filter; search/paging state lives in the feed - SearchTab fires all three feeds with typed inputs (posts/quotes/catalogue search), superseding per feed — no view debounce - The old blog layer (BlogModel, actions, env keys, cells) is deleted: its last consumers (the quotes piggyback and SearchTab) migrated here Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Stack 3/4 (on #234). Quotes adopts the BlogTab pattern wholesale; SearchTab migrates with it, which lets the old blog layer retire.
QuotesQuerydrives the@Querypredicate (QuoteRecord.quotes), the network fetch, and the re-fetch trigger; view-ownedFeedPagestate; row-driven frontier paging; pull-to-refresh + paging in browse and search alikeGET /api/quotesdirectly (paged, server-filtered by languages + sources) — the catalogue/blog piggyback refresh is gone, and browse gains paginationQuotesModelslims to the source filter — search/paging state lives in the feedVerification
swift test --package-path app-core— 49 tests green (old BlogModel suite retired with the model)🤖 Generated with Claude Code