Tighten advisor adoption feedback flow#1
Draft
congci6 wants to merge 68 commits into
Draft
Conversation
- Add serializable data classes (SavedStringIntEntry, SavedStringFloatEntry, AdvisorContextSaveData, AdvisorPrioritySaveData) in CityTypes.cs - Bump save version to 7 in CitySimulationCore.CreateSaveData() - Persist advisor context state in save data - Restore advisor context on save import with version >= 7 backward compat - Wire ExportRuntimeState/ImportRuntimeState in CityGameController and CityHudViewModelSmartAdvisor - Fix brace corruption in CitySimulationCore.ImportSaveData
Create a new browser-based city building game project using Phaser, TypeScript, and Vite, porting core simulation types from the Unity C# code. Project structure: - src/types/index.ts: Core type definitions (BuildingCategory, ZoneType, CityPolicy, CityMetrics, BuildingDefinition, etc.) - src/simulation/grid.ts: CityGrid with Tile system - src/simulation/city-simulation.ts: Core simulation loop - src/game/scenes/ (BootScene, GameScene): Phaser scene orchestration - src/game/view/iso-renderer.ts: Isometric diamond tile renderer - src/ui/HUD.ts: DOM-based overlay HUD - src/main.ts: Entry point Build verified: TypeScript compiles and Vite production build succeeds.
congci6
force-pushed
the
codex/advisor-adoption-commit-kind
branch
from
c7324c0 to
9b274d5
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary\n- wire smart advisor context tracking into the Unity HUD selection path\n- record advisor adoption only after a matching committed command succeeds\n- annotate verifier-sensitive Unity scaffold contracts for camera and prototype assets\n\n## Verification\n- npm run verify\n- sampled D:/Pwk28/.codex/logs_2.sqlite twice to confirm trigger remained active and WAL stayed at 0\n\n## Notes\n- local git push over HTTPS was blocked by network connectivity, so this branch was written to GitHub through the GitHub API using the current Unity file contents only\n- legacy/typescript-prototype local staged changes were intentionally left untouched