Skip to content

fix(desktop): point beforeBuildCommand at the root Makefile#93

Merged
cnjack merged 1 commit into
mainfrom
fix/desktop-before-build-command
Jun 21, 2026
Merged

fix(desktop): point beforeBuildCommand at the root Makefile#93
cnjack merged 1 commit into
mainfrom
fix/desktop-before-build-command

Conversation

@cnjack

@cnjack cnjack commented Jun 21, 2026

Copy link
Copy Markdown
Owner

Problem

The v0.6.2 release pipeline failed in the desktop bundle job:

Running beforeBuildCommand `make build-web`
make: *** No rule to make target `build-web'.  Stop.

The Build desktop bundle step runs with working-directory: desktop, so Tauri's beforeBuildCommand executes from desktop/. There is no Makefile there — the build-web target lives in the repo root.

Fix

beforeBuildCommand: make build-webmake -C .. build-web, so the root target resolves from the desktop dir in both CI and local make desktop-build.

Verified with a dry-run from desktop/: make -C .. -n build-web resolves and runs the web build. JSON validated.

🤖 Generated with Claude Code

The Tauri `beforeBuildCommand` ran `make build-web`, but the desktop bundle
step runs from `desktop/` (working-directory: desktop) where there is no
Makefile — the `build-web` target lives in the repo root. The v0.6.2 release
failed with "make: *** No rule to make target `build-web'".

Use `make -C ..` so the root target resolves from the desktop dir, in both CI
and local `make desktop-build`.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
@coderabbitai

coderabbitai Bot commented Jun 21, 2026

Copy link
Copy Markdown

Warning

Review limit reached

@cnjack, we couldn't start this review because you've reached your PR review rate limit.

More reviews will be available in 44 minutes and 44 seconds. Learn how PR review limits work.

Your organization has used up its prepaid credits, and credit purchases are no longer available. Enable the review add-on in the billing tab to keep reviews running — you're only billed for reviews past your plan's rate limits ($0.25/file).

⌛ How to resolve this issue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based credits.

🚦 How do rate limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan refill rate.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, the refill rate gradually slows as usage increases. The highest same-day bursts are limited more strictly.

Please see our Fair Usage Limits Policy for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: cad69816-82e5-4554-84c7-ae7956259bf9

📥 Commits

Reviewing files that changed from the base of the PR and between 89fd095 and bbb2211.

📒 Files selected for processing (1)
  • desktop/src-tauri/tauri.conf.json
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/desktop-before-build-command

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@cnjack cnjack merged commit fb98a8a into main Jun 21, 2026
3 checks passed
@cnjack cnjack deleted the fix/desktop-before-build-command branch June 21, 2026 17:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant