Skip to content

fix(build): make build-web generate web assets first#94

Merged
cnjack merged 1 commit into
mainfrom
fix/build-web-generate
Jun 21, 2026
Merged

fix(build): make build-web generate web assets first#94
cnjack merged 1 commit into
mainfrom
fix/build-web-generate

Conversation

@cnjack

@cnjack cnjack commented Jun 21, 2026

Copy link
Copy Markdown
Owner

Problem

After fixing the make build-web path (#93), the v0.6.2 desktop jobs failed deeper — the web build couldn't resolve generated files on a clean checkout:

Can't resolve './styles/tokens.generated.css'
Could not resolve './themes.generated' in src/composables/useTheme.ts

web/src/styles/tokens.generated.css and web/src/composables/themes.generated.ts are produced by the theme generator (go generate ./internal/theme/...) and are gitignored. The desktop job's sidecar step uses a plain go build and never runs make generate, so those files don't exist when Tauri's beforeBuildCommand runs make -C .. build-web.

Fix

Make build-web depend on generate, so the frontend build is self-contained (also fixes local make desktop-build).

Verified locally by deleting both generated files and running make -C .. build-web from desktop/ — they regenerate and vite build succeeds (exit 0).

🤖 Generated with Claude Code

The desktop bundle job runs `make -C .. build-web` (via Tauri
beforeBuildCommand) but never runs `make generate` beforehand — the sidecar
step does a plain `go build`. The theme generator's outputs
(web/src/styles/tokens.generated.css and web/src/composables/themes.generated.ts)
are gitignored, so vite build failed on a clean checkout:

  Can't resolve './styles/tokens.generated.css'
  Could not resolve './themes.generated' in src/composables/useTheme.ts

Make `build-web` depend on `generate` so the frontend build is self-contained.
Verified locally by deleting both generated files and running
`make -C .. build-web` from desktop/ — they regenerate and the build succeeds.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
@coderabbitai

coderabbitai Bot commented Jun 21, 2026

Copy link
Copy Markdown

Warning

Review limit reached

@cnjack, we couldn't start this review because you've reached your PR review rate limit.

More reviews will be available in 35 minutes and 43 seconds. Learn how PR review limits work.

Your organization has used up its prepaid credits, and credit purchases are no longer available. Enable the review add-on in the billing tab to keep reviews running — you're only billed for reviews past your plan's rate limits ($0.25/file).

⌛ How to resolve this issue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based credits.

🚦 How do rate limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan refill rate.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, the refill rate gradually slows as usage increases. The highest same-day bursts are limited more strictly.

Please see our Fair Usage Limits Policy for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 9873efe1-436d-4f5b-9f4e-a6f8d516d304

📥 Commits

Reviewing files that changed from the base of the PR and between fb98a8a and 82349a0.

📒 Files selected for processing (1)
  • Makefile
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/build-web-generate

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@cnjack cnjack merged commit c23b41c into main Jun 21, 2026
3 checks passed
@cnjack cnjack deleted the fix/build-web-generate branch June 21, 2026 17:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant