Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,7 @@ import androidx.compose.foundation.layout.padding
import androidx.compose.material3.ExperimentalMaterial3Api
import androidx.compose.material3.Text
import androidx.compose.runtime.Composable
import androidx.compose.runtime.LaunchedEffect
import androidx.compose.runtime.getValue
import androidx.compose.ui.Alignment
import androidx.compose.ui.Modifier
Expand Down Expand Up @@ -46,9 +47,8 @@ internal fun UserProfileEmailRow(

val isPreview = LocalInspectionMode.current
val state by viewModel.state.collectAsStateWithLifecycle()
if (state is EmailViewModel.State.Failure) {
onError((state as EmailViewModel.State.Failure).message)
}
ReportEmailRowError(state, onError)

ClerkMaterialTheme {
Row(
modifier =
Expand Down Expand Up @@ -101,6 +101,16 @@ internal fun UserProfileEmailRow(
}
}

@Composable
internal fun ReportEmailRowError(state: EmailViewModel.State, onError: (String) -> Unit) {
val errorMessage = (state as? EmailViewModel.State.Failure)?.message
LaunchedEffect(errorMessage) {
if (errorMessage != null) {
onError(errorMessage)
}
}
}

@Composable
private fun EmailWithBadge(isPrimary: Boolean, emailAddress: EmailAddress) {
Column {
Expand Down
Original file line number Diff line number Diff line change
@@ -0,0 +1,33 @@
package com.clerk.ui.userprofile.email

import androidx.compose.material3.Text
import androidx.compose.runtime.LaunchedEffect
import androidx.compose.runtime.getValue
import androidx.compose.runtime.mutableIntStateOf
import androidx.compose.runtime.setValue
import com.clerk.base.BaseSnapshotTest
import kotlin.test.Test
import kotlin.test.assertEquals

class UserProfileEmailRowTest : BaseSnapshotTest() {

@Test
fun failureState_reportsErrorOnceAcrossRecomposition() {
val reportedErrors = mutableListOf<String>()
val callbackVersions = mutableListOf<Int>()
var recompositionTrigger by mutableIntStateOf(0)

paparazzi.snapshot {
val callbackVersion = recompositionTrigger
ReportEmailRowError(EmailViewModel.State.Failure("Unable to update email")) {
reportedErrors += it
callbackVersions += callbackVersion
}
Text(recompositionTrigger.toString())
LaunchedEffect(Unit) { recompositionTrigger++ }
}

assertEquals(listOf("Unable to update email"), reportedErrors)
assertEquals(listOf(0), callbackVersions)
}
}