Report email row errors only once across recomposition - #830
Conversation
|
Warning Review limit reached
Next review available in: 58 minutes Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (2)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
89e78c9 to
1c20b57
Compare
Summary
LaunchedEffectso recomposition does not re-fire the callback.Testing
Note
Fix
UserProfileEmailRowerror callback firing on every recompositionInline
onErrorinvocation during composition inUserProfileEmailRowcaused repeated callbacks (e.g. duplicate snackbars) on recomposition. A newReportEmailRowErrorcomposable wraps the callback in aLaunchedEffectkeyed by the error message, soonErrorfires only once per distinct error. A Compose test verifies the callback is invoked exactly once despite multiple recompositions.🖇️ Linked Issues
Resolves MOBILE-612, which identified that
UserProfileEmailRow.ktinvokedonErrorinline during composition rather than as a side effect.Macroscope summarized 1c20b57.