Skip to content

RiverLea 1.4.1: inline data fields, contact dashboard prev/next on WP, .crm-buttons - #32370

Merged
mattwire merged 3 commits into
civicrm:masterfrom
vingle:1.4.1
Mar 14, 2025
Merged

RiverLea 1.4.1: inline data fields, contact dashboard prev/next on WP, .crm-buttons#32370
mattwire merged 3 commits into
civicrm:masterfrom
vingle:1.4.1

Conversation

@vingle

@vingle vingle commented Mar 13, 2025

Copy link
Copy Markdown
Contributor

Overview

This includes all the changes from version 1.4.0 plus two fixes and an addition.

Before

Start/end date
image
and in add CiviCase/Activity:
image

WordPress prev/next
image
(there's a bigger bug displayed here, which renders a button illegible, but I couldn't recreate it)

Multi-buttons:
There is no container class to put multiple buttons together with a consistent gap around them - just lots of specific code doing that, and hacks (ie adding margin around button css).

After

Start/end date
image
and in add CiviCase/Activity
image

Use of class when only one date or dates are stacked (on 'add event') are unaffected:
image
image

WordPress prev/next
image

Multi-buttons:
There's now a new utility class .crm-buttons that extends an existing flexbox pattern, and adds flex-box wrap. cc @ufundo, this was inspired on from seeing the lack of gap in the Customiser buttons and realising there's not utility class to solve that.

Comments

Apologies for including #32351 - my bad for not putting that in a branch I guess – am new to having multiple PRs open on the same files that are different versions.. but I suppose I can either merge this with both PRs, or after the other one is merged, I can rebase this?

@civibot

civibot Bot commented Mar 13, 2025

Copy link
Copy Markdown

🤖 Thank you for contributing to CiviCRM! ❤️ We will need to test and review this PR. 👷

Introduction for new contributors...
  • If this is your first PR, an admin will greenlight automated testing with the command ok to test or add to whitelist.
  • A series of tests will automatically run. You can see the results at the bottom of this page (if there are any problems, it will include a link to see what went wrong).
  • A demo site will be built where anyone can try out a version of CiviCRM that includes your changes.
  • If this process needs to be repeated, an admin will issue the command test this please to rerun tests and build a new demo site.
  • Before this PR can be merged, it needs to be reviewed. Please keep in mind that reviewers are volunteers, and their response time can vary from a few hours to a few weeks depending on their availability and their knowledge of this particular part of CiviCRM.
  • A great way to speed up this process is to "trade reviews" with someone - find an open PR that you feel able to review, and leave a comment like "I'm reviewing this now, could you please review mine?" (include a link to yours). You don't have to wait for a response to get started (and you don't have to stop at one!) the more you review, the faster this process goes for everyone 😄
  • To ensure that you are credited properly in the final release notes, please add yourself to contributor-key.yml
  • For more information about contributing, see CONTRIBUTING.md.
Quick links for reviewers...

➡️ Online demo of this PR 🔗

@civibot civibot Bot added the master label Mar 13, 2025
@mattwire
mattwire merged commit bb23a24 into civicrm:master Mar 14, 2025
vingle added a commit to vingle/civicrm-core that referenced this pull request Mar 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants