RiverLea 1.4.1: inline data fields, contact dashboard prev/next on WP, .crm-buttons - #32370
Merged
Conversation
|
🤖 Thank you for contributing to CiviCRM! ❤️ We will need to test and review this PR. 👷 Introduction for new contributors...
Quick links for reviewers...
|
vingle
added a commit
to vingle/civicrm-core
that referenced
this pull request
Mar 17, 2025
Backport of civicrm#32370
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
This includes all the changes from version 1.4.0 plus two fixes and an addition.
.crm-buttonsto provide uniform gap and wrap around multiple buttons, as no other class provides this - and instead it's handled on a case-by-case basis which is a waste of css. Not used anywhere currently, but referenced in discussion: Riverlea - add stream preview/edit to admin page #32344 & https://lab.civicrm.org/extensions/riverlea/-/issues/101.Before
Start/end date


and in add CiviCase/Activity:
WordPress prev/next

(there's a bigger bug displayed here, which renders a button illegible, but I couldn't recreate it)
Multi-buttons:
There is no container class to put multiple buttons together with a consistent gap around them - just lots of specific code doing that, and hacks (ie adding margin around button css).
After
Start/end date


and in add CiviCase/Activity
Use of class when only one date or dates are stacked (on 'add event') are unaffected:


WordPress prev/next

Multi-buttons:
There's now a new utility class
.crm-buttonsthat extends an existing flexbox pattern, and adds flex-box wrap. cc @ufundo, this was inspired on from seeing the lack of gap in the Customiser buttons and realising there's not utility class to solve that.Comments
Apologies for including #32351 - my bad for not putting that in a branch I guess – am new to having multiple PRs open on the same files that are different versions.. but I suppose I can either merge this with both PRs, or after the other one is merged, I can rebase this?