Skip to content

RiverLea Thames Dark Mode / Extensions colour fix - #32393

Merged
ufundo merged 1 commit into
civicrm:6.1from
vingle:patch-2
Mar 17, 2025
Merged

RiverLea Thames Dark Mode / Extensions colour fix #32393
ufundo merged 1 commit into
civicrm:6.1from
vingle:patch-2

Conversation

@vingle

@vingle vingle commented Mar 17, 2025

Copy link
Copy Markdown
Contributor

Port-forward (Forport?) of #32370 in response to @Stoob's issue: https://lab.civicrm.org/dev/core/-/issues/5793

Overview

This fixes a regression caused by #31994. I tested that PR and made a bunch of changes to regressions in #32209, but hadn't tested Extensions layout in Thames dark-mode, so am adding this. @artfulrobot feel free to change/resubmit your own, trying to be helpful here.

I'm going for the simplest fix - change bg to be dark, using a shade of green used elsewhere in Thames/DarkMode.

More info and screengrabs - please see the first PR.

@civibot

civibot Bot commented Mar 17, 2025

Copy link
Copy Markdown

🤖 Thank you for contributing to CiviCRM! ❤️ We will need to test and review this PR. 👷

Introduction for new contributors...
  • If this is your first PR, an admin will greenlight automated testing with the command ok to test or add to whitelist.
  • A series of tests will automatically run. You can see the results at the bottom of this page (if there are any problems, it will include a link to see what went wrong).
  • A demo site will be built where anyone can try out a version of CiviCRM that includes your changes.
  • If this process needs to be repeated, an admin will issue the command test this please to rerun tests and build a new demo site.
  • Before this PR can be merged, it needs to be reviewed. Please keep in mind that reviewers are volunteers, and their response time can vary from a few hours to a few weeks depending on their availability and their knowledge of this particular part of CiviCRM.
  • A great way to speed up this process is to "trade reviews" with someone - find an open PR that you feel able to review, and leave a comment like "I'm reviewing this now, could you please review mine?" (include a link to yours). You don't have to wait for a response to get started (and you don't have to stop at one!) the more you review, the faster this process goes for everyone 😄
  • To ensure that you are credited properly in the final release notes, please add yourself to contributor-key.yml
  • For more information about contributing, see CONTRIBUTING.md.
Quick links for reviewers...

➡️ Online demo of this PR 🔗

@ufundo

ufundo commented Mar 17, 2025

Copy link
Copy Markdown
Contributor

I think its a forward port of #32381 but apart from that looks good @vingle

@ufundo
ufundo merged commit 88251a6 into civicrm:6.1 Mar 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants