Skip to content

Fix NullPointerException, target tracking, and banking loops #490

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
VIPDO1 wants to merge 2 commits into
base: main
Choose a base branch
from
+61 −40
Open

Fix NullPointerException, target tracking, and banking loops #490

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9ed32e6
Thieving: Replaced broken 50s timers and isInteracting checks with co…
VIPDO1 Jun 18, 2026
7931c6a
Thieving: Replaced broken 50s timers and isInteracting checks with co…
VIPDO1 Jun 18, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/main/java/net/runelite/client/plugins/microbot/housethieving/HouseThievingPlugin.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@
name = PluginDescriptor.Maxxin + "House Thieving",
description = "House Thieving",
tags = {"thieving", "house thieving"},
authors = {"Maxxin"},
authors = {"Maxxin, VIP (just fixed something)"},
version = HouseThievingPlugin.version,
minClientVersion = "2.0.7",
iconUrl = "https://chsami.github.io/Microbot-Hub/HouseThievingPlugin/assets/icon.png",
Expand All @@ -26,7 +26,7 @@
)
@Slf4j
public class HouseThievingPlugin extends Plugin {
public final static String version = "1.0.3";
public final static String version = "1.0.4";
@Inject
private HouseThievingConfig config;

Expand Down
97 changes: 59 additions & 38 deletions src/main/java/net/runelite/client/plugins/microbot/housethieving/HouseThievingScript.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,7 @@

import javax.annotation.Nullable;
import java.util.Comparator;
import java.util.List;
import java.util.concurrent.TimeUnit;
import java.util.stream.Collectors;

Expand All @@ -48,10 +49,12 @@ enum State {
private Long lastThievingSearch = null;
private ThievingHouse currentThievingHouse = null;
private Rs2NpcModel pickpocketNpc = null;

private final static String HOUSE_KEYS = "House keys";
private final static String DODGY_NECKLACE = "Dodgy necklace";
private final static String COIN_POUCH = "Coin pouch";
private final static String WEALTHY_CITIZEN = "Wealthy citizen";
private final static List<Integer> BANKER_IDS = List.of(13212, 13213, 13214, 13215);

public boolean run(HouseThievingConfig config) {
Microbot.pauseAllScripts.compareAndSet(true, false);
Expand Down Expand Up @@ -182,7 +185,7 @@ private void handlePickPocketing(HouseThievingConfig config) {

var targetWealthyCitizen = distractedWealthyCitizen != null ? distractedWealthyCitizen : pickpocketNpc;
if (targetWealthyCitizen != null) {
if (distractedWealthyCitizen == null) { // Regular pickpocketing
if (distractedWealthyCitizen == null) {
if (Rs2Inventory.getInventoryFood().isEmpty()) {
state = State.BANKING;
return;
Expand Down Expand Up @@ -283,7 +286,6 @@ private void handleFindingHouse(HouseThievingConfig config) {
}

private void attemptWaitForHouseNpc(Rs2NpcModel houseNpc) {
// Try to determine if NPC is leaving or not - could maybe look at overhead text?
if (houseNpc != null) {
var overheadText = houseNpc.getOverheadText();
if (overheadText != null && !overheadText.isEmpty()) {
Expand Down Expand Up @@ -317,38 +319,40 @@ private void handleThievingHouse(Rs2NpcModel houseNpc) {
}
}

if (Rs2Player.isMoving()) {
return;
}

Rs2TileObjectModel targetObject = currentThievingObject;

var hintArrow = Microbot.getClient().getHintArrowPoint();
var elapsedTime = lastThievingSearch == null ? null : System.currentTimeMillis() - lastThievingSearch;
if (hintArrow == null) {
if (currentThievingObject == null) {
var tileObject = Rs2Tile.getTile(currentThievingHouse.initialThievingChest.getX(), currentThievingHouse.initialThievingChest.getY());
if (tileObject != null) {
currentThievingObject = Microbot.getRs2TileObjectCache().query().nearest(currentThievingHouse.initialThievingChest, 3);
if (!Rs2Camera.isTileOnScreen(currentThievingObject.getLocalLocation())) {
Rs2Camera.turnTo(currentThievingObject);
}
currentThievingObject.click("Search");
}
currentThievingObject = Microbot.getRs2TileObjectCache().query().nearest(currentThievingHouse.initialThievingChest, 3);
if (hintArrow != null) {
var arrowObject = Microbot.getRs2TileObjectCache().query().nearest(hintArrow, 3);
if (arrowObject != null) {
targetObject = arrowObject;
}
}

if (currentThievingObject != null && (lastThievingSearch == null || (elapsedTime != null && elapsedTime > 50000))) {
if (!Rs2Camera.isTileOnScreen(currentThievingObject.getLocalLocation())) {
Rs2Camera.turnTo(currentThievingObject);
}
currentThievingObject.click("Search");
lastThievingSearch = System.currentTimeMillis();
Rs2Random.waitEx(1000.0, 200.0);
}
} else {
currentThievingObject = Microbot.getRs2TileObjectCache().query().nearest(hintArrow, 3);
if (!Rs2Player.isInteracting() || lastThievingSearch == null || (elapsedTime != null && elapsedTime > 50000)) {
if (!Rs2Camera.isTileOnScreen(currentThievingObject.getLocalLocation())) {
Rs2Camera.turnTo(currentThievingObject);
if (targetObject == null) {
targetObject = Microbot.getRs2TileObjectCache().query().nearest(currentThievingHouse.initialThievingChest, 3);
}

if (targetObject != null) {
boolean isNewTarget = currentThievingObject == null ||
targetObject.getId() != currentThievingObject.getId() ||
targetObject.getWorldLocation().distanceTo(currentThievingObject.getWorldLocation()) > 0;

if (isNewTarget) {
if (!Rs2Camera.isTileOnScreen(targetObject.getLocalLocation())) {
Rs2Camera.turnTo(targetObject);
}
currentThievingObject.click("Search");

targetObject.click("Search");

currentThievingObject = targetObject;
lastThievingSearch = System.currentTimeMillis();
Rs2Random.waitEx(1000.0, 200.0);

Rs2Random.waitEx(600.0, 100.0);
}
}
}
Expand All @@ -363,8 +367,10 @@ private boolean exitHouse() {
}
Microbot.getRs2TileObjectCache().query().withId(windowTileWallObject.getId()).interact("Exit-window");
Rs2Random.waitEx(5000.0, 200.0);

currentThievingObject = null;
lastThievingSearch = null;

setNextThievingHouse();
state = State.FINDING_HOUSE;
return true;
Expand Down Expand Up @@ -394,17 +400,31 @@ private void handleBanking(HouseThievingConfig config) {
return;
}

if (Rs2Player.getWorldLocation().distanceTo(BANKING_LOCATION) > 3) {
Rs2Walker.walkTo(BANKING_LOCATION, 2);
if (Rs2Player.isMoving()) {
return;
}

if (!Rs2Bank.isOpen() && Rs2Player.distanceTo(BANKING_LOCATION) <= 3) {
var bankingTile = Microbot.getRs2TileObjectCache().query().nearest(BANKING_TILE_LOCATION, 3);
if (bankingTile != null)
Rs2Bank.openBank(bankingTile);
else
if (!Rs2Bank.isOpen()) {
if (Rs2Player.getWorldLocation().distanceTo(BANKING_LOCATION) > 2) {
Rs2Walker.walkTo(BANKING_LOCATION, 2);
return;
}

var banker = Microbot.getRs2NpcCache().query()
.where(npc -> BANKER_IDS.contains(npc.getId()))
.nearestOnClientThread();

if (banker != null) {
if (!Rs2Camera.isTileOnScreen(banker.getLocalLocation())) {
Rs2Camera.turnTo(banker);
}
banker.click("Bank");
} else {
Rs2Bank.openBank();
sleepUntil(Rs2Bank::isOpen, 2);
}

sleepUntil(Rs2Bank::isOpen, 5000);
return;
}

if (Rs2Bank.isOpen()) {
Expand Down Expand Up @@ -440,6 +460,7 @@ private void handleBanking(HouseThievingConfig config) {
Rs2Inventory.waitForInventoryChanges(600);
}
}
Rs2Bank.closeBank();
}
}

Expand Down Expand Up @@ -497,4 +518,4 @@ public void shutdown() {
super.shutdown();
}

}
}