Skip to content

fix sentry upload from frontend build + make it blocking#1688

Merged
Pascal-Delange merged 1 commit into
mainfrom
fix/sentry-upload-non-fatal
Jun 25, 2026
Merged

fix sentry upload from frontend build + make it blocking#1688
Pascal-Delange merged 1 commit into
mainfrom
fix/sentry-upload-non-fatal

Conversation

@Pascal-Delange

@Pascal-Delange Pascal-Delange commented Jun 25, 2026

Copy link
Copy Markdown
Contributor

A version bump in the sentry CLI makes uploading release & source maps fail (silently), because it now depends on local CA certificates.
I also changed a config to make it blocking when this happens, because I found out totally randomly by reading the CI logs.

Summary by CodeRabbit

  • Bug Fixes

    • Improved build reliability by ensuring certificate verification works during container builds.
    • Surfaced sourcemap upload failures so release builds don’t pass when uploads fail.
  • Refactor

    • Updated route mappings to match the current app navigation structure.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ChibiBlasphem not sure what's happening with this, I'm getting this diff in all of my PRs?

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems that's a change related to tanstack version update but the file hasn't be regenerated

@coderabbitai

coderabbitai Bot commented Jun 25, 2026

Copy link
Copy Markdown

Review Change Stack

Warning

Review limit reached

@Pascal-Delange, we couldn't start this review because you've reached your PR review rate limit.

More reviews will be available in 17 minutes and 40 seconds. Learn how PR review limits work.

Your organization has used up its prepaid credits, and credit purchases are no longer available. Enable the review add-on in the billing tab to keep reviews running — you're only billed for reviews past your plan's rate limits ($0.25/file).

⌛ How to resolve this issue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based credits.

🚦 How do rate limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please see our Fair Usage Limits Policy for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: db32f3e6-0df9-4cc5-8545-95bff31ade4d

📥 Commits

Reviewing files that changed from the base of the PR and between 332dbb9 and 857a7a2.

📒 Files selected for processing (3)
  • Dockerfile
  • packages/app-builder/src/routeTree.gen.ts
  • packages/app-builder/vite.config.ts
📝 Walkthrough

Walkthrough

The Docker build stage now installs ca-certificates. Generated app-builder route typings were updated for two paths, and Vite Sentry sourcemap uploads now rethrow errors.

Changes

Docker build-stage TLS certificates

Layer / File(s) Summary
Install CA certificates
Dockerfile
The build stage runs apt-get update, installs ca-certificates, and removes apt lists.

App builder route typings

Layer / File(s) Summary
Update generated route map
packages/app-builder/src/routeTree.gen.ts
FileRoutesByFullPath now maps /cases and /detection/scenarios/$scenarioId/i/$iterationId to the updated route types.

App builder sourcemap failure handling

Layer / File(s) Summary
Rethrow sourcemap upload errors
packages/app-builder/vite.config.ts
sentryVitePlugin now includes a sourcemaps errorHandler that throws the received error.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Poem

In Docker’s forge, new certs take root and stand,
Two routes find names anew through app-builder’s hand.
When sourcemaps falter, they shall not be still—
They cry their error forth, by build and will.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately summarizes the Sentry upload fix and the blocking failure behavior in the frontend build.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/sentry-upload-non-fatal

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@Pascal-Delange Pascal-Delange force-pushed the fix/sentry-upload-non-fatal branch from 332dbb9 to 857a7a2 Compare June 25, 2026 09:03

@ChibiBlasphem ChibiBlasphem left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@Pascal-Delange Pascal-Delange merged commit 890a507 into main Jun 25, 2026
7 checks passed
@Pascal-Delange Pascal-Delange deleted the fix/sentry-upload-non-fatal branch June 25, 2026 09:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants